[Xfce4-commits] r23230 - in xarchiver/branches/xarchiver-psybsd: . libxarchiver src

[Stephan Arts]

Author: stephan
Date: 2006-09-28 13:07:33 +0000 (Thu, 28 Sep 2006)
New Revision: 23230

Modified:
   xarchiver/branches/xarchiver-psybsd/TODO
   xarchiver/branches/xarchiver-psybsd/libxarchiver/archive-support-gnu-tar.c
   xarchiver/branches/xarchiver-psybsd/libxarchiver/internals.c
   xarchiver/branches/xarchiver-psybsd/libxarchiver/libxarchiver.c
   xarchiver/branches/xarchiver-psybsd/src/main.c
Log:
updated todo
placed filenames between ""



Modified: xarchiver/branches/xarchiver-psybsd/TODO
===================================================================
--- xarchiver/branches/xarchiver-psybsd/TODO	2006-09-28 12:38:50 UTC (rev 23229)
+++ xarchiver/branches/xarchiver-psybsd/TODO	2006-09-28 13:07:33 UTC (rev 23230)
@@ -8,24 +8,6 @@
 | IMPORTANT                                         IMPORTANT |
 ---------------------------------------------------------------
 
-+-+-+-+
-	Fix 'Stop' Segfault
-
-+-+-+-+
-	
-  Fix table column stuff work correctly
-+-+-+-+
-
-  Implement table-columns to gnu-tar archive;
-+-+-+-+
-
-  Speedup GUI
-+-+-+-+
-
-	Implement View support (for all support-objects)
-		Use Path-entries for path-components. (Should reduce mem-usage on large archives tremendously)
-+-+-+-+
-
 	Implement UnRar Support object.
 +-+-+-+
 

Modified: xarchiver/branches/xarchiver-psybsd/libxarchiver/archive-support-gnu-tar.c
===================================================================
--- xarchiver/branches/xarchiver-psybsd/libxarchiver/archive-support-gnu-tar.c	2006-09-28 12:38:50 UTC (rev 23229)
+++ xarchiver/branches/xarchiver-psybsd/libxarchiver/archive-support-gnu-tar.c	2006-09-28 13:07:33 UTC (rev 23230)
@@ -105,6 +105,7 @@
 
 	lxa_archive_support_add_mime(archive_support, "application/x-tar");
 	/* Check for existence of compress -- required for x-tarz */
+	/* TODO: free return value of g_find_program_in_path */
 	if(g_find_program_in_path("compress"))
 		lxa_archive_support_add_mime(archive_support, "application/x-tarz");
 	/* Check for existence of gzip -- required for x-compressed-tar*/
@@ -278,7 +279,7 @@
 			if(!g_strcasecmp((gchar *)archive->mime, "application/x-tar"))
 			{
 				command = g_strconcat(LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->app_name, " -xf ", archive->path,
-						" -C ", dest_path, 
+						" -C \"", dest_path, "\"", 
 						LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->_extr_overwrite?" --overwrite ":" ",
 						LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->_extr_touch?" --touch ":" ",
 						archive->files, NULL);
@@ -286,7 +287,7 @@
 			if(!g_strcasecmp((gchar *)archive->mime, "application/x-tarz"))
 			{
 				command = g_strconcat(LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->app_name, " -Zxf ", archive->path,
-						" -C ", dest_path, 
+						" -C \"", dest_path, "\"", 
 						LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->_extr_overwrite?" --overwrite ":" ",
 						LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->_extr_touch?" --touch ":" ",
 						archive->files, NULL);
@@ -294,7 +295,7 @@
 			if(!g_strcasecmp((gchar *)archive->mime, "application/x-compressed-tar"))
 			{
 				command = g_strconcat(LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->app_name, " -zxf ", archive->path,
-						" -C ", dest_path, 
+						" -C \"", dest_path, "\"", 
 						LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->_extr_overwrite?" --overwrite ":" ",
 						LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->_extr_touch?" --touch ":" ",
 						archive->files, NULL);
@@ -302,7 +303,7 @@
 			if(!g_strcasecmp((gchar *)archive->mime, "application/x-bzip-compressed-tar"))
 			{
 				command = g_strconcat(LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->app_name, " -jxf ", archive->path,
-						" -C ", dest_path, 
+						" -C \"", dest_path, "\"", 
 						LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->_extr_overwrite?" --overwrite ":" ",
 						LXA_ARCHIVE_SUPPORT_GNU_TAR(archive->support)->_extr_touch?" --touch ":" ",
 						archive->files, NULL);

Modified: xarchiver/branches/xarchiver-psybsd/libxarchiver/internals.c
===================================================================
--- xarchiver/branches/xarchiver-psybsd/libxarchiver/internals.c	2006-09-28 12:38:50 UTC (rev 23229)
+++ xarchiver/branches/xarchiver-psybsd/libxarchiver/internals.c	2006-09-28 13:07:33 UTC (rev 23230)
@@ -124,7 +124,7 @@
 	while(_filenames)
 	{
 		_concat_str = concat_str;
-		concat_str = g_strconcat(concat_str, " ", _filenames->data,  NULL);
+		concat_str = g_strconcat(concat_str, " \"", _filenames->data,"\"",  NULL);
 		_filenames = _filenames->next;
 		g_free(_concat_str);
 	}

Modified: xarchiver/branches/xarchiver-psybsd/libxarchiver/libxarchiver.c
===================================================================
--- xarchiver/branches/xarchiver-psybsd/libxarchiver/libxarchiver.c	2006-09-28 12:38:50 UTC (rev 23229)
+++ xarchiver/branches/xarchiver-psybsd/libxarchiver/libxarchiver.c	2006-09-28 13:07:33 UTC (rev 23230)
@@ -47,6 +47,7 @@
 void
 lxa_destroy()
 {
+	g_slist_foreach(lxa_archive_support_list, (GFunc)g_object_unref, NULL);
 	g_object_unref(lxa_mime_database);
 }
 

Modified: xarchiver/branches/xarchiver-psybsd/src/main.c
===================================================================
--- xarchiver/branches/xarchiver-psybsd/src/main.c	2006-09-28 12:38:50 UTC (rev 23229)
+++ xarchiver/branches/xarchiver-psybsd/src/main.c	2006-09-28 13:07:33 UTC (rev 23230)
@@ -269,6 +269,7 @@
 			return 0;
 
 	gtk_main();
+	lxa_destroy();
 
 	return 0;
 }