[Xfce4-commits] r26652 - xfdesktop/branches/xfce_4_4/modules/menu

Brian Tarricone kelnos at xfce.org
Thu Feb 28 14:37:25 CET 2008


Author: kelnos
Date: 2008-02-28 13:37:25 +0000 (Thu, 28 Feb 2008)
New Revision: 26652

Modified:
   xfdesktop/branches/xfce_4_4/modules/menu/desktop-menuspec.c
Log:
plug 2 memleaks; misunderstanding of how arg 2 of g_ptr_array_free() works

found using corsac's valgrind log on bug 2427


Modified: xfdesktop/branches/xfce_4_4/modules/menu/desktop-menuspec.c
===================================================================
--- xfdesktop/branches/xfce_4_4/modules/menu/desktop-menuspec.c	2008-02-28 13:36:56 UTC (rev 26651)
+++ xfdesktop/branches/xfce_4_4/modules/menu/desktop-menuspec.c	2008-02-28 13:37:25 UTC (rev 26652)
@@ -203,7 +203,7 @@
                 else
                     foundcat = NULL;
                 if(!foundcat) {
-                    g_ptr_array_free(revpath, FALSE);
+                    g_ptr_array_free(revpath, TRUE);
                     revpath = NULL;
                     break;
                 }
@@ -220,7 +220,7 @@
                 newpath[totlen] = 0;
                 
                 g_ptr_array_add(mtfpi->paths, newpath);
-                g_ptr_array_free(revpath, FALSE);
+                g_ptr_array_free(revpath, TRUE);
             }
         }
     }



More information about the Xfce4-commits mailing list